fix: handle uppercase units and functions #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
commented
Mar 27, 2019
| return { left, right }; | ||
| } | ||
|
|
||
| export default convertNodes; |
There was a problem hiding this comment.
Already CRLF
alexander-akait
commented
Mar 27, 2019
| if (right.type === left.type) { | ||
| right = { | ||
| type: left.type, | ||
| value: convertUnits(right.value, right.unit.toLowerCase(), left.unit.toLowerCase(), precision), |
There was a problem hiding this comment.
Only add .toLowerCase() because original module doesn't support uppercase notation
alexander-akait
commented
Mar 27, 2019
| /* lexical grammar */ | ||
| %lex | ||
|
|
||
| %options case-insensitive |
There was a problem hiding this comment.
Added this
alexander-akait
commented
Mar 27, 2019
| | ANGLE { $$ = { type: 'AngleValue', value: parseFloat($1), unit: /[a-z]+/i.exec($1)[0] }; } | ||
| | TIME { $$ = { type: 'TimeValue', value: parseFloat($1), unit: /[a-z]+/i.exec($1)[0] }; } | ||
| | FREQ { $$ = { type: 'FrequencyValue', value: parseFloat($1), unit: /[a-z]+/i.exec($1)[0] }; } | ||
| | RES { $$ = { type: 'ResolutionValue', value: parseFloat($1), unit: /[a-z]+/i.exec($1)[0] }; } |
There was a problem hiding this comment.
Added i flag
alexander-akait
commented
Mar 27, 2019
| | VMAXS { $$ = { type: 'VmaxValue', value: parseFloat($1), unit: 'vmax' }; } | ||
| | PERCENTAGE { $$ = { type: 'PercentageValue', value: parseFloat($1), unit: '%' }; } | ||
| | SUB css_value { var prev = $2; prev.value *= -1; $$ = prev; } | ||
| ; |
There was a problem hiding this comment.
Already CRLF
jonathantneal
approved these changes
Mar 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.